aws/request: Ensure New request handles nil retryer #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds additional default behavior to the SDK's New request constructor, to handle the case where a nil Retryer was passed in. This error could occur when the SDK's Request type was being used to create requests directly, not through one of the SDK's client. Fixes aws#2889
jasdel
added
the
needs-review
skotambkar
reviewed
Nov 7, 2019
skotambkar
approved these changes
Nov 7, 2019
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Nov 8, 2019
=== ### Service Client Updates * `service/cognito-identity`: Updates service API and documentation * `service/ecr`: Updates service documentation * This release contains ticket fixes for Amazon ECR. ### SDK Bugs * `aws/request`: Ensure New request handles nil retryer ([#2934](#2934)) * Adds additional default behavior to the SDK's New request constructor, to handle the case where a nil Retryer was passed in. This error could occur when the SDK's Request type was being used to create requests directly, not through one of the SDK's client. * Fixes [#2889](#2889)
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Nov 8, 2019
Release v1.25.31 (2019-11-08) === ### Service Client Updates * `service/cognito-identity`: Updates service API and documentation * `service/ecr`: Updates service documentation * This release contains ticket fixes for Amazon ECR. ### SDK Bugs * `aws/request`: Ensure New request handles nil retryer ([#2934](#2934)) * Adds additional default behavior to the SDK's New request constructor, to handle the case where a nil Retryer was passed in. This error could occur when the SDK's Request type was being used to create requests directly, not through one of the SDK's client. * Fixes [#2889](#2889)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional default behavior to the SDK's New request constructor,
to handle the case where a nil Retryer was passed in. This error could
occur when the SDK's Request type was being used to create requests
directly, not through one of the SDK's client.
Fixes #2889