Fixes codegen for multiple account ids #4608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
force-pushed
the
fix-codegen-accountid
branch
from
859fc78
to
2993610
Compare
sbiscigl
commented
Nov 2, 2022
| @@ -76,11 +76,15 @@ const accountIDWithARNShapeTmplDef = ` | |||
| {{ range $_, $name := $.MemberNames -}} | |||
| {{ $elem := index $.MemberRefs $name -}} | |||
| {{ if $elem.AccountIDMemberWithARN -}} | |||
| {{ $FunctionName := $name }} | |||
| {{ if eq $name "AccountId" }} | |||
| {{ $FunctionName = "AccountID" }} | |||
There was a problem hiding this comment.
we have to change AccountId to AccountID to support backwards compatibility. if we wanted to drop it, we could removed this if statement.
sbiscigl
force-pushed
the
fix-codegen-accountid
branch
from
2993610
to
fbad6e2
Compare
isaiahvita
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changes to files under the
/model/folder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.If there is an existing bug or feature this PR is answers please reference it here.
When a model has multiple elements where
if $elem.AccountIDMemberWithARNis true it will create the same function signature for each elementThis updates the function signature to take the shape name into account