Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable regabi due to stability issues during codegen #4245

Merged
merged 1 commit into from Jan 18, 2022

Conversation

skmcgrail
Copy link
Member

For changes to files under the /model/ folder, and manual edits to autogenerated code (e.g. /service/s3/api.go) please create an Issue instead of a PR for those type of changes.

If there is an existing bug or feature this PR is answers please reference it here.

@skmcgrail skmcgrail requested a review from jasdel January 18, 2022 18:51
@skmcgrail skmcgrail changed the title Disable regabi due to on-going stability issues Disable regabi due to on-going stability issues during codegen Jan 18, 2022
@skmcgrail skmcgrail changed the title Disable regabi due to on-going stability issues during codegen Disable regabi due to stability issues during codegen Jan 18, 2022
@skmcgrail skmcgrail merged commit 2a3e589 into aws:main Jan 18, 2022
@skmcgrail skmcgrail deleted the nonregabi branch January 18, 2022 19:28
jasdel added a commit to jasdel/aws-sdk-go that referenced this pull request Apr 18, 2022
jasdel added a commit that referenced this pull request Apr 20, 2022
This reverts commit 2a3e589.

Reverts REGABI disabling change since the issue was resolved in Go 1.17.6, and no longer impacts the SDK's code generation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants