Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/s3: Update unit test to clarify implemented behavior #4033

Merged
merged 1 commit into from Jul 28, 2021

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Jul 28, 2021

Updates Amazon S3 Output ARN unit test to more specifically describe the behavior that is being tested.

If the client's resolved endpoint's signing region does not match the Output ARN's region component the client will return the region not match error. If the client's resolved endpoint's signing region does match the Output ARN's region component, but the API client's configured region includes FIPS, the FIPS configured error will be returned.

Updates Amazon S3 Output ARN unit test to more specifically describe the
behavior that is being tested.

If the client's resolved endpoint's signing region does not match the
Output ARN's region component the client will return the region not
match error. If the client's resolved endpoint's signing region does
match the Output ARN's region component, but the API client's configured
region includes FIPS, the FIPS configured error will be returned.
@jasdel jasdel requested a review from skotambkar July 28, 2021 18:43
@jasdel jasdel merged commit abb47fb into aws:main Jul 28, 2021
@jasdel jasdel deleted the issue/S3Endpoint branch July 28, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants