Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private: Adds support for httpChecksumRequired trait #3272

Merged
merged 7 commits into from May 26, 2020
Merged

private: Adds support for httpChecksumRequired trait #3272

merged 7 commits into from May 26, 2020

Conversation

skotambkar
Copy link
Contributor

@skotambkar skotambkar commented Apr 17, 2020 •
edited

This PR contains s3 model changes that should NOT be merged.

  • Adds support for httpChecksumRequired trait
  • Adds expected model changes for testing
  • Moves contentMd5 handler func from s3 to private/utils
  • Removes customizations for specific operations requiring Content-MD5 header
  • Adds and modifies existing tests for service operations decorated by the trait.

@skotambkar skotambkar self-assigned this Apr 17, 2020
@skotambkar skotambkar added blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. needs-review This issue or pull request needs review from a core team member. labels Apr 17, 2020
@skotambkar skotambkar marked this pull request as ready for review April 28, 2020 22:44
@skotambkar skotambkar changed the title private: Adds support for httpContentMd5 trait private: Adds support for httpChecksumRequired trait May 13, 2020
jasdel
jasdel suggested changes May 13, 2020
View reviewed changes
service/s3/body_hash.go Outdated Show resolved Hide resolved
private/util/content_md5.go Outdated Show resolved Hide resolved
private/util/content_md5.go Outdated Show resolved Hide resolved
private/util/content_md5.go Outdated Show resolved Hide resolved
@skotambkar skotambkar requested a review from jasdel May 13, 2020 20:17
jasdel
jasdel reviewed May 18, 2020
View reviewed changes
aws/types.go Outdated Show resolved Hide resolved
@skotambkar skotambkar requested a review from jasdel May 18, 2020 23:45
@skotambkar skotambkar merged commit bcb2cf3 into aws:master May 26, 2020
@skotambkar skotambkar deleted the c2j/md5-trait branch May 26, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

@skmcgrail skmcgrail Awaiting requested review from skmcgrail

Assignees

@skotambkar skotambkar

Labels
blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skotambkar @jasdel