Fix streaming APIs' Err method closing stream #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
added
the
needs-review
skmcgrail
reviewed
Oct 10, 2019
private/model/api/eventstream.go
Outdated
| if !ok { | ||
| t.Fatalf("expect stream not to be closed, but was") | ||
| } | ||
| default: |
There was a problem hiding this comment.
Do we need to generate a default empty case?
There was a problem hiding this comment.
This default case is triggered when the case channel would block. The chan read case will trigger if the Events channel is closed. This check is asserting that the channel returned by the Events method is blocking.
skmcgrail
approved these changes
Oct 10, 2019
Fixes calling the Err method on SDK's Amazon Kinesis's SubscribeToShared and Amazon S3's SelectObjectContent response EventStream members closing the stream. This would cause unexpected read errors, or early termination of the streams. Only the Close method of the streaming members will close the streams. Improved generated unit and integration tests for streaming API operations. Related to aws#2769
jasdel
force-pushed
the
issue-2769/S3SelectObjectStream
branch
from
e135ecd
to
dddcc33
Compare
jasdel
force-pushed
the
issue-2769/S3SelectObjectStream
branch
from
dddcc33
to
108b9a1
Compare
skotambkar
reviewed
Oct 11, 2019
| @@ -7379,6 +7379,8 @@ type SubscribeToShardEventStream struct { | |||
| // may result in resource leaks. | |||
| func (es *SubscribeToShardEventStream) Close() (err error) { | |||
| es.Reader.Close() | |||
| es.StreamCloser.Close() | |||
There was a problem hiding this comment.
Do we need to handle the error, if there is one when trying to close a Reader or StreamCloser?
skotambkar
approved these changes
Oct 11, 2019
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Oct 22, 2019
=== ### Service Client Updates * `service/iotevents`: Updates service API and documentation * `service/opsworkscm`: Updates service API and documentation * AWS OpsWorks for Chef Automate (OWCA) now allows customers to use a custom domain and respective certificate, for their AWS OpsWorks For Chef Automate servers. Customers can now provide a CustomDomain, CustomCertificate and CustomPrivateKey in CreateServer API to configure their Chef Automate servers with a custom domain and certificate. ### SDK Bugs * `service/s3`,`service/kinesis`: Fix streaming APIs' Err method closing stream ([#2882](#2882)) * Fixes calling the Err method on SDK's Amazon Kinesis's SubscribeToShared and Amazon S3's SelectObjectContent response EventStream members closing the stream. This would cause unexpected read errors, or early termination of the streams. Only the Close method of the streaming members will close the streams. * Related to [#2769](#2769)
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Oct 22, 2019
Release v1.25.17 (2019-10-22) === ### Service Client Updates * `service/iotevents`: Updates service API and documentation * `service/opsworkscm`: Updates service API and documentation * AWS OpsWorks for Chef Automate (OWCA) now allows customers to use a custom domain and respective certificate, for their AWS OpsWorks For Chef Automate servers. Customers can now provide a CustomDomain, CustomCertificate and CustomPrivateKey in CreateServer API to configure their Chef Automate servers with a custom domain and certificate. ### SDK Bugs * `service/s3`,`service/kinesis`: Fix streaming APIs' Err method closing stream ([#2882](#2882)) * Fixes calling the Err method on SDK's Amazon Kinesis's SubscribeToShared and Amazon S3's SelectObjectContent response EventStream members closing the stream. This would cause unexpected read errors, or early termination of the streams. Only the Close method of the streaming members will close the streams. * Related to [#2769](#2769)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes calling the Err method on SDK's Amazon Kinesis's SubscribeToShared and Amazon S3's SelectObjectContent response EventStream members closing the stream. This would cause unexpected read errors, or early termination of the streams. Only the Close method of the streaming members will close the streams.
Improved generated unit and integration tests for streaming API operations.
Related to #2769