Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamodb: Guidance for map keys with dots in dynamodb.expression #2570

Closed
zombie-guru opened this issue Apr 23, 2019 · 7 comments
Closed

dynamodb: Guidance for map keys with dots in dynamodb.expression #2570

zombie-guru opened this issue Apr 23, 2019 · 7 comments
Labels
closed-for-staleness enhancement Change to SDK that resolves an issue improves existing functionality. feature-request A feature should be added or improved. needs-contributors

Comments

@zombie-guru
Copy link

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

v1.19.15

Version of Go (go version)?

go version go1.12.1 darwin/amd64

What issue did you see?

Not possible with the expression package to delete map keys with . in them.

As an example, I would like to delete the My.Key.With.Dots in a M attribute named MyMap using the expression package. Some code is below. However, the REMOVE statement ends up being:

REMOVE #0.#1.#2.#3.#4

Happy to contribute a possible solution but was wondering if there are any solutions for this.

Steps to reproduce

package main

import (
	"fmt"

	"github.com/aws/aws-sdk-go/aws"
	"github.com/aws/aws-sdk-go/service/dynamodb/expression"
)

func main() {
	expr, err := expression.NewBuilder().
		WithUpdate(expression.Remove(expression.Name("MyMap.My.Key.With.Dots"))).
		Build()
}
@diehlaws diehlaws self-assigned this Apr 26, 2019
@diehlaws diehlaws added the feature-request A feature should be added or improved. label Apr 26, 2019
@diehlaws
Copy link
Contributor

Thanks for bringing this behavior to our attention @zombie-guru. Unfortunately what you are attempting to do is not possible at this time with the DynamoDB Expression Builder in the AWS SDK for Go. I'll bring this up with the rest of the team during our next sprint to discuss the best way to handle this case - if you'd like to submit a PR to fix this behavior please be sure to read our contribution guidelines before submitting the PR and we'd be happy to review it.

@jasdel jasdel added the enhancement Change to SDK that resolves an issue improves existing functionality. label Apr 30, 2019
@vitaly-zdanevich
Copy link
Contributor

My related question https://stackoverflow.com/questions/61022482/is-it-possible-to-set-to-map-when-key-contains-dot

About PR: as I understand before PR we need to design some new syntax.

@vitaly-zdanevich
Copy link
Contributor

Please do not ignore this issue :(

@diehlaws
Copy link
Contributor

Hi @vitaly-zdanevich, apologies for the delay in response on this issue. We've had an investigation task for this on our backlog for some time. I've brought it up with the rest of the team and we'll be reprioritizing investigating how to best implement this feature. Once we have more information on its progress I'll update the issue accordingly.

@vitaly-zdanevich
Copy link
Contributor

Because this is also about condition expression.

@diehlaws diehlaws removed their assignment Aug 26, 2020
@odannyc
Copy link

odannyc commented Dec 16, 2020

Hi, I am also running into this issue. Any updates?

@github-actions
Copy link

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness enhancement Change to SDK that resolves an issue improves existing functionality. feature-request A feature should be added or improved. needs-contributors
Projects
None yet
Development

No branches or pull requests

6 participants