codegen: Add flag to direct if SDK is allowed to modify a custom endpoint or not #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
jasdel/cust/EndpointResolver
branch
6 times, most recently
from
820bca7
to
5a6aa47
Compare
jasdel
force-pushed
the
jasdel/cust/EndpointResolver
branch
from
89ad0e2
to
56b5074
Compare
jasdel
force-pushed
the
jasdel/cust/EndpointResolver
branch
4 times, most recently
from
a6d3fa6
to
045c367
Compare
|
Fixes up a bug with the S3 endpoint resolve tests for virtual host path style that should resolve to path style for bucket names that are not valid hostname labels. This fallback is not used when accelerate is enabled. Applies a couple fixes to s3 and s3control endpoint resolve tests to cover hostname immutable support. |
skmcgrail
reviewed
Oct 26, 2020
...hy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/EndpointGenerator.java
Show resolved
Hide resolved
skmcgrail
approved these changes
Oct 26, 2020
skotambkar
approved these changes
Oct 26, 2020
jasdel
force-pushed
the
jasdel/cust/EndpointResolver
branch
from
045c367
to
7c42e83
Compare
…oint or not Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API. If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false. - Fixes #827 (SDK requiring region for endpoint resolution) - Fixes #328 - Fixes #364 - Related to #836 When Amazon S3 Accesspoint support is implemented. - Related to #479 Depends on aws/smithy-go#222
jasdel
force-pushed
the
jasdel/cust/EndpointResolver
branch
3 times, most recently
from
c458604
to
fc76253
Compare
jasdel
force-pushed
the
jasdel/cust/EndpointResolver
branch
from
5a591c3
to
8eb8fc3
Compare
lggomez
added a commit
to lggomez/aws-sdk-go-v2
that referenced
this pull request
Apr 26, 2022
lggomez
added a commit
to lggomez/aws-sdk-go-v2
that referenced
this pull request
Apr 26, 2022
jasdel
pushed a commit
that referenced
this pull request
May 5, 2022
…es (#1683) Updates the doc string for hostCompatibleBucketName adding link to the resolved Endpoint member driving the behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new member to the
aws.Endpointstruct,HostnameImmutable. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API. IfHostnameImmutableis true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false.Depends on aws/smithy-go#222