Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor operation builders to only modify the middleware stack within their own module's context #2507

Open
lucix-aws opened this issue Feb 20, 2024 · 1 comment
Open

Refactor operation builders to only modify the middleware stack within their own module's context #2507

lucix-aws opened this issue Feb 20, 2024 · 1 comment
Labels
feature-request A feature should be added or improved. queued This issues is on the AWS team's backlog

Comments

@lucix-aws
Copy link
Contributor

lucix-aws commented Feb 20, 2024 •
edited

This will categorically prevent compatibility fractures such as #2370 going forward.
@lucix-aws lucix-aws added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Feb 20, 2024
@lucix-aws lucix-aws mentioned this issue Feb 20, 2024
Closed
@prochac
Copy link

prochac commented Feb 22, 2024 •
edited

Did you also consider using retract go.mod directive?
I know that these things happen, but the retract directive could help module users identify the root cause much faster.
https://go.dev/ref/mod#go-mod-file-retract

@lucix-aws lucix-aws mentioned this issue Feb 22, 2024
Merged
@lucix-aws lucix-aws mentioned this issue Mar 5, 2024
Closed
@lucix-aws lucix-aws mentioned this issue Mar 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. queued This issues is on the AWS team's backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prochac @lucix-aws