Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not backfill session-name for SSO Token Provider #1846

Closed
skmcgrail opened this issue Sep 15, 2022 · 2 comments · Fixed by #1903
Closed

Should not backfill session-name for SSO Token Provider #1846

skmcgrail opened this issue Sep 15, 2022 · 2 comments · Fixed by #1903
Assignees
Labels
bug This issue is a bug.

Comments

@skmcgrail
Copy link
Member

if ssoSession == nil {
// Fallback to legacy SSO session config parameters, if the
// sso-session section wasn't used.
ssoSession = &SSOSession{
Name: sharedConfig.SSOStartURL,
SSORegion: sharedConfig.SSORegion,
SSOStartURL: sharedConfig.SSOStartURL,
}
}

@RanVaknin RanVaknin added bug This issue is a bug. needs-review This issue or pull request needs review from a core team member. labels Sep 19, 2022
@skmcgrail skmcgrail removed the needs-review This issue or pull request needs review from a core team member. label Oct 19, 2022
@isaiahvita
Copy link
Contributor

isaiahvita commented Oct 24, 2022

specifically, i believe the conditional linked above should be deleted, and an error should be returned if the SSOSession is not set. this is because the SSOTokenProvider is required to rely on a certain format (the existence of the SSOSession). Falling back to a legacy format used by by a different provider (SSOCredentialProvider) should not be supported.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants