Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BuildAuthToken to validate endpoint contains a port #1837

Conversation

RanVaknin
Copy link
Contributor

  • Validated that the right side of the colon has to be an string representation of an integer
  • Added test cases to validate type of error and if an error should be returned.

Copy link
Member

@skmcgrail skmcgrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets get a release note added to this before merging.

@skmcgrail skmcgrail force-pushed the fix-rds-auth-connect-with-invalid-port-error-message branch from ccb3c57 to 4ae827c Compare September 12, 2022 21:18
@skmcgrail skmcgrail changed the title validated that the right side of the colon has to be an string representation of an integer Update BuildAuthToken to validate endpoint contains a port Sep 12, 2022
@skmcgrail skmcgrail merged commit 63566f0 into aws:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDS's 'BuildAuthToken' should validate that the port is present in the database endpoint string
2 participants