Upgrade to smithy 1.25.0 #1835
Merged
Upgrade to smithy 1.25.0 #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update EC2 unboxed shapes to boxed shapes backfill customization Due to changes in smithy 2.0 nullability semantics around the `@box` trait, the generated code for `ec2.json` generated incorrect code. Instead of adding `@box` traits to certain members in the customization, the `@clientOptional` trait is added to members of all structure shapes. Chores: - Add mavenLocal to codegen build files - Update .gitignore to ignore .idea/
Due to prior bugs for `@box` members not being serialized as a pointer type and incorrect pagination serialization, the clients in this commit are regenerated with the break/fix's.
syall
force-pushed
the
nullability-fix
branch
from
fe18c6e
to
f525157
Compare
jasdel
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on Smithy 1.25.0 release and aws/smithy-go#386, BLOCK merging until then.
For changes to files under the
/model/folder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.N/A
If there is an existing bug or feature this PR is answers please reference it here.
N/A
Description of changes:
Note: This change introduces break/fix's for pointable types.
Update EC2 unboxed shapes to boxed shapes backfill customization
Due to changes in smithy 2.0 nullability semantics around the
@boxtrait, the generated code forec2.jsongenerated incorrect code.Instead of adding
@boxtraits to certain members in the customization, the@clientOptionaltrait is added to members of all structure shapes.Chores:
Regenerate clients with break/fix's
Due to prior bugs for
@boxmembers not being serialized as a pointer type and incorrect pagination serialization, the clients in this commit are regenerated with the break/fix's.Testing:
./gradlew clean build publishToMavenLocal smithy-cli:runtimemake smithy-clean smithy-build smithy-publish-local smithy-cleanmake generateandmake unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.