Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/s3/manager: Downloader fails on Windows with Go1.19 #1790

Closed
jasdel opened this issue Aug 4, 2022 · 2 comments
Closed

feature/s3/manager: Downloader fails on Windows with Go1.19 #1790

jasdel opened this issue Aug 4, 2022 · 2 comments
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@jasdel
Copy link
Contributor

jasdel commented Aug 4, 2022

Describe the bug

The SDK's download manager is failing its unit tests with Go 1.19 on Windows. Discovered when adding Go 1.19 to CI for the SDK. It seems like the SDK's default buffer pool used on windows is contributing to this issue.

defaultUploadBufferProvider

This may be blocking usage of the transfer manager on Windows with Go 1.19.

Expected Behavior

Unit tests to pass, and transfer manager to work on all supported Go versions and platforms

Current Behavior

Unit tests failing.

Reproduction Steps

Run unit tests on Windows with Go 1.19

Possible Solution

Workaround is to delete or comment out feature/s3/manager/default_read_seeker_write_to_windows.go and feature/s3/manager/default_writer_read_from_windows.go files.

Additional Information/Context

No response

AWS Go SDK V2 Module Versions Used

latest

Compiler and Version used

go1.19

Operating System and version

windows

@jasdel jasdel added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 4, 2022
@jasdel
Copy link
Contributor Author

jasdel commented Aug 11, 2022

This issue was resolved in PR #1785 correcting the transfer manager on windows behavior with regard to io.NopCloser forwarding io.WriterAt in Go1.19.

@jasdel jasdel closed this as completed Aug 11, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

1 participant