Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/awstesting: Update SDK custom certificate testing utils #1626

Merged
merged 3 commits into from Mar 30, 2022

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Mar 16, 2022

Updates the SDK's custom certificate testing utilities to be compatible
with Go 1.18's deprecating of SHA1. Switch from static openssl generated
certificates to generate certificates at package initialization.

Related to aws/aws-sdk-go#4316

Updates the SDK's custom certificate testing utilities to be compatible
with Go 1.18's deprecating of SHA1. Switch from static openssl generated
certificates to generate certificates at package initialization.

Related to aws/aws-sdk-go#4316
@jasdel jasdel requested a review from skmcgrail March 16, 2022 22:59

// CreateClientTLSCertFiles returns a set of temporary files for the client
// certificate and key files.
func CreateClientTLSCertFiles() (cert, key string, err error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these actually need to be written out to disk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the v1 SDK yes since it supports the AWS_SDK_GO_CLIENT_TLS_KEY environment variables. Though it doesn't look like the v2 SDK has this behavior for some reason. Will have to investigate why that is missing.

@jasdel jasdel merged commit b03e3da into aws:main Mar 30, 2022
@jasdel jasdel deleted the fixup/CACertTests branch March 30, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants