Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stscreds.AssumeRoleProvider does not support the sts.AssumeRoleInput field SourceIdentity #1575

Closed
3 tasks done
gdavison opened this issue Jan 28, 2022 · 1 comment · Fixed by #1588
Closed
3 tasks done
Labels
bug This issue is a bug.

Comments

@gdavison
Copy link
Contributor

Documentation

Describe the bug

I would like to use the default stscreds.AssumeRoleProvider to assume a role while specifying a SourceIdentity.

SourceIdentity was added to sts.AssumeRoleInput in the release on 14 April 2021, but the corresponding field was not added to stscreds.AssumeRoleProvider.

Expected behavior

stscreds.AssumeRoleProvider should be in sync with sts.AssumeRoleInput

Current behavior

The default stscreds.AssumeRoleProvider cannot be used to assume a role while specifying a SourceIdentity.

Steps to Reproduce

The following code snippet fails to compile

appCreds := stscreds.NewAssumeRoleProvider(client, ar.RoleARN, func(opts *stscreds.AssumeRoleOptions) {
	...

	opts. SourceIdentity = aws.String(sourceIdentity)

	...
})

Possible Solution

No response

AWS Go SDK version used

2022-01-14

Compiler and Version used

N/A

Operating System and version

N/A

@gdavison gdavison added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 28, 2022
jasdel pushed a commit that referenced this issue Feb 22, 2022
…1588)

Adds support for SourceIdentity to stscreds.AssumeRoleProvider. Fixes #1575
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@vudh1 vudh1 removed the needs-triage This issue or PR still needs to be triaged. label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants