Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK DefaultsMode Configuration Implementation #1553

Merged
merged 2 commits into from Jan 14, 2022
Merged

SDK DefaultsMode Configuration Implementation #1553

merged 2 commits into from Jan 14, 2022

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Jan 10, 2022 •
edited

@skmcgrail skmcgrail requested a review from jasdel January 10, 2022 23:38
@skmcgrail skmcgrail force-pushed the defaults branch 5 times, most recently from 5602db8 to de9bc51 Compare January 12, 2022 19:27
jasdel
jasdel reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple comments.

aws/defaults/configuration.go Outdated Show resolved Hide resolved
aws/defaultsmode.go Outdated Show resolved Hide resolved
config/resolve_test.go Outdated Show resolved Hide resolved
config/shared_config.go Outdated Show resolved Hide resolved
config/shared_config_test.go Outdated Show resolved Hide resolved
internal/codegen/cmd/defaultsconfig/v1.go Show resolved Hide resolved
@skmcgrail skmcgrail requested a review from jasdel January 13, 2022 03:15
jasdel
jasdel approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comment about extra code might not be needed anymore.

aws/defaults/configuration.go Outdated Show resolved Hide resolved
@skmcgrail skmcgrail merged commit c1b62ab into aws:main Jan 14, 2022
@skmcgrail skmcgrail deleted the defaults branch January 14, 2022 01:07
jrichard8 pushed a commit to jrichard8/aws-sdk-go-v2 that referenced this pull request Feb 14, 2022
@skmcgrail @jrichardpfs
SDK DefaultsMode Configuration Implementation (aws#1553)
9b405f2 
* SDK Default Configuration Implementation
* Regeneration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skmcgrail @jasdel