Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass KeyTag to dynamo attributevalue marshalling #1494

Closed
1 task done
radutopala opened this issue Nov 13, 2021 · 2 comments · Fixed by #1495
Closed
1 task done

Pass KeyTag to dynamo attributevalue marshalling #1494

radutopala opened this issue Nov 13, 2021 · 2 comments · Fixed by #1495
Labels
feature-request A feature should be added or improved.

Comments

@radutopala
Copy link
Contributor

Describe the feature

As a AWS SDK go v2 user, I want to be able to set a custom KeyTag on attributevalue.MarshalMap, so I can keep the compatibility with previous v1 SDK.

Is your Feature Request related to a problem?

Currently the attributevalue.MarshalMap doesn't accept the Encoder options, even though it is possible without breaking changes.

By default, KeyTag is set to dynamoav. Passing the Encoder options will allow setting up a KeyTag like json.

Proposed Solution

No response

Describe alternatives you've considered

No response

Acknowledge

  • I may be able to implement this feature request

AWS Go SDK version used

v2

Go version used

1.16
@radutopala radutopala added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 13, 2021
@radutopala radutopala mentioned this issue Nov 13, 2021
Merged
@jasdel jasdel mentioned this issue Dec 3, 2021
Closed
3 tasks
@jasdel
Copy link
Contributor

jasdel commented Dec 3, 2021

Thanks for taking the time to create this issue, and PR. I left feedback in the PR. Adding a new set of MarshalWithOptions and similarly UnmarshalWithOptions functions to the package would allow this functionality to be used without breaking the existing function signatures.

@jasdel jasdel removed the needs-triage This issue or PR still needs to be triaged. label Dec 3, 2021
@jasdel jasdel mentioned this issue Dec 3, 2021
Closed
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i1494 passing opts to attributevalue marshalling radutopala/aws-sdk-go-v2
2 participants
@radutopala @jasdel