license check action #1460
Merged
license check action #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
reviewed
Oct 14, 2021
|
Other then the one comment the changes look good. |
|
yea the action assumes that main is the target branch, but base_ref should work, though I think the diff command would have to change too. |
skmcgrail
approved these changes
Oct 14, 2021
skotambkar
pushed a commit
to skotambkar/aws-sdk-go-v2
that referenced
this pull request
Oct 15, 2021
* license check action
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
* license check action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changes to files under the
/model/folder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.If there is an existing bug or feature this PR is answers please reference it here.
This action checks for the files modified by a PR and scans them for Licenses, failing if it finds a new license added, removed or modified.
For this check failure doesn't mean "don't merge" but "make sure it's safe".
There will be false positives on the license detection, but there should be no false negatives.