s3: make streaming operations use unsigned payload by default #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
force-pushed
the
s3-default-to-unsignedpayload
branch
from
9dd369e
to
83bbc10
Compare
skotambkar
force-pushed
the
s3-default-to-unsignedpayload
branch
2 times, most recently
from
d794480
to
b8c9e38
Compare
skotambkar
force-pushed
the
s3-default-to-unsignedpayload
branch
from
b8c9e38
to
febfd4c
Compare
skotambkar
commented
Oct 15, 2021
...src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3ContentSHA256Header.java
Outdated
Show resolved
Hide resolved
jasdel
suggested changes
Oct 18, 2021
...src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3ContentSHA256Header.java
Outdated
Show resolved
Hide resolved
jasdel
suggested changes
Oct 20, 2021
...src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3ContentSHA256Header.java
Outdated
Show resolved
Hide resolved
skotambkar
force-pushed
the
s3-default-to-unsignedpayload
branch
from
457deca
to
8711da2
Compare
jasdel
approved these changes
Oct 20, 2021
skmcgrail
approved these changes
Oct 20, 2021
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
…aws#1354) Adds SwapPayloadSHA256ResolverMiddleware that swaps computPayloadSHA256 middleware if an S3 operation uses streaming payload. For S3 operations with streaming payload, we use unsigned payload strategy if TLS is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
SwapPayloadSHA256ResolverMiddlewarethat swaps computPayloadSHA256 middleware if an S3 operation uses streaming payload.For S3 operations with streaming payload, we use unsigned payload strategy if TLS is enabled.