feat: (feature/dynamodb/expression) re-add IsSet methods #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaquestion
changed the title
|
@skmcgrail @jasdel Any reason this can't come in? Seems non-controversial, but if you've got a different vision in mind for doing this check happy to code up a different solution. |
skmcgrail
approved these changes
Jul 20, 2021
|
Sorry for the delay in reviewing this change @zaquestion and thank you for bring this to our attention that this was mistakenly removed when we changed the location of the package. I've pushed an update to your branch to include a changelog annotation for our next release, otherwise the change looks good. |
skmcgrail
approved these changes
Jul 20, 2021
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
* feat: (feature/dynamodb/expression) readd IsSet methods These changes were present in an older version of the expression package before it was moved, originally added in aws#494, when the expression library was reintroduce in aws#981 these changes werent included for some reason, but the need for checking if a condition is set or not still exists * Add Change Annotation Co-authored-by: Sean McGrail <mcgrails@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were present in an older version of the expression package before it was moved, originally added in #494, when the expression library was reintroduce in #981 these changes werent included for some reason, but the need for checking if a condition is set or not still exists