Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EC2 IMDS Client Does Not Support Logger or ClientLogMode which prevents logging of HTTP Request and Responses #1323

Closed
skmcgrail opened this issue Jun 29, 2021 · 2 comments
Closed

EC2 IMDS Client Does Not Support Logger or ClientLogMode which prevents logging of HTTP Request and Responses #1323

skmcgrail opened this issue Jun 29, 2021 · 2 comments
Assignees
@RanVaknin
Labels
bug This issue is a bug.

Comments

@skmcgrail
Copy link
Member

skmcgrail commented Jun 29, 2021 •
edited

EC2 IMDS Client does not attach the RequestResponseLogger deserialize middleware which results in the ClientLogMode options being ignored.

Additionally the IMDS client does not call AddSetLoggerMiddleware to register the clients logger with the stack middleware.

When fixing this issue the Logger and ClientLogMode will also need to support being resolved from aws.Config via the NewFromConfig constructor.
@skmcgrail skmcgrail added the bug This issue is a bug. label Jun 29, 2021
@skmcgrail skmcgrail changed the title EC2 IMDS Client Does Not Support ClientLogMode of HTTP Request and Response EC2 IMDS Client Does Not Support Logger or ClientLogMode which prevents logging of HTTP Request and Responses Jun 29, 2021
@RanVaknin RanVaknin self-assigned this Oct 20, 2022
@RanVaknin RanVaknin mentioned this issue Oct 21, 2022
Merged
@RanVaknin RanVaknin added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Oct 22, 2022
@RanVaknin
Copy link
Contributor

PR #1891 fixes this issue.

@RanVaknin RanVaknin removed the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Oct 22, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RanVaknin RanVaknin

Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skmcgrail @RanVaknin