Carve out internal/ini into a seperate module
#1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the CI updates in my PR didn't correctly flag go |
skotambkar
reviewed
May 19, 2021
skotambkar
approved these changes
May 20, 2021
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
* Detect Module Carving Out * internal/ini: Carve out ini parser as stand-alone module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR "carves out"
internal/iniinto a separate module. This will allow for future changes / improvements to this package code to be done without causing a core module bump with cascading dependency bumps.Additionally support has been added to the
calculatereleasetool to detect carve out scenarios and properly detect the parent module as requiring tagging.