From 681bedb160b45ce1847deb8d627fa96007bf70ce Mon Sep 17 00:00:00 2001 From: Ran Vaknin Date: Thu, 15 Sep 2022 15:21:49 -0700 Subject: [PATCH 1/3] better description for Credentials object --- aws/config.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/aws/config.go b/aws/config.go index ac8bfd0c614..20153586bae 100644 --- a/aws/config.go +++ b/aws/config.go @@ -26,9 +26,9 @@ type Config struct { // information on AWS regions. Region string - // The credentials object to use when signing requests. Defaults to a - // chain of credential providers to search for credentials in environment - // variables, shared credential file, and EC2 Instance Roles. + // The credentials object to use when signing requests. + // Use the LoadDefaultConfig to load configuration from all the SDK's supported + // sources, and resolve credentials using the SDK's default credential chain. Credentials CredentialsProvider // The Bearer Authentication token provider to use for authenticating API From 3f34bd0b7ea39c5ec6f3f98e46494b0eacdfb5b8 Mon Sep 17 00:00:00 2001 From: Ran Vaknin Date: Mon, 19 Sep 2022 12:36:35 -0700 Subject: [PATCH 2/3] added changelog statment --- .changelog/0bce3cb2c3d74dc7a87d4943339d1cec.json | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 .changelog/0bce3cb2c3d74dc7a87d4943339d1cec.json diff --git a/.changelog/0bce3cb2c3d74dc7a87d4943339d1cec.json b/.changelog/0bce3cb2c3d74dc7a87d4943339d1cec.json new file mode 100644 index 00000000000..9ca413f35f7 --- /dev/null +++ b/.changelog/0bce3cb2c3d74dc7a87d4943339d1cec.json @@ -0,0 +1,8 @@ +{ + "id": "0bce3cb2-c3d7-4dc7-a87d-4943339d1cec", + "type": "documentation", + "description": "added clafirfication on the Credential object to show usage of loadDefaultConfig to load credentials", + "modules": [ + "." + ] +} \ No newline at end of file From 72c90fe7599debacfdbad474e4d954547b9132a6 Mon Sep 17 00:00:00 2001 From: Ran Vaknin Date: Mon, 19 Sep 2022 14:08:48 -0700 Subject: [PATCH 3/3] updated linting ignore --- .golangci.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.golangci.toml b/.golangci.toml index 75e338858d4..8792d0ca6b1 100644 --- a/.golangci.toml +++ b/.golangci.toml @@ -6,7 +6,7 @@ modules-download-mode = "readonly" allow-parallel-runners = true skip-dirs = ["internal/repotools"] skip-dirs-use-default = true - +skip-files = ["service/transcribestreaming/eventstream_test.go"] [output] format = "github-actions"