fix(storage): Stop transfer service if all transfers complete #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjroach
changed the title
Merged
6 tasks
sdhuka
approved these changes
Jul 22, 2022
| @@ -137,7 +142,8 @@ public int onStartCommand(Intent intent, int flags, int startId) { | |||
| * b) An identifier for the ongoing notification c) Flag that determines if the notification | |||
| * needs to be removed when the service is moved out of the foreground state. | |||
| */ | |||
| if (Build.VERSION.SDK_INT >= ANDROID_OREO) { | |||
| if (Build.VERSION.SDK_INT >= ANDROID_OREO && !hasNotificationShown) { | |||
There was a problem hiding this comment.
do we need hasNotificationShown check here?
There was a problem hiding this comment.
I didn't want to re-trigger showing the same notification again, which could look glitchy if you were observing the drawer and the notification kept getting recreated
sktimalsina
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Amplify 1803
Description of changes:
When a transfer completes, check to see if there are any other transfers in progress. If not, stop the ongoing TransferService
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.