Fix(pinpoint) 2762: Resolve Android 12 notification trampolining restrictions and ADM Push Notifications #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sktimalsina
reviewed
Jun 8, 2022
| @@ -0,0 +1,59 @@ | |||
| /** | |||
| * Copyright 2016-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Thanks, I'll update. In making the change, I had renamed PinpointNotificationReceiver to PinpointNotificationActivity. PinpointNotificationActivity now looks like a new file, since I added a shell PinpointNotificationReciever back.
|
|
||
| /** | ||
| * The Amazon Pinpoint push notification receiver. | ||
| * @deprecated This class is no longer functional and will soon be removed. At one point, |
sdhuka
previously approved these changes
Jun 8, 2022
sktimalsina
previously approved these changes
Jun 8, 2022
sdhuka
previously approved these changes
Jun 8, 2022
tjleing
previously approved these changes
Jun 8, 2022
…fix' into tjroach/notification-trampoline-fix
tylerjroach
dismissed stale reviews from tjleing, sdhuka, and sktimalsina
via
e6bf12c
|
This PR will also fix issue: 2927 |
tylerjroach
changed the title
tjleing
reviewed
Jun 9, 2022
|
|
||
| @Before | ||
| public void setup() { | ||
| PinpointNotificationActivity.setNotificationClient((NotificationClient) null); |
There was a problem hiding this comment.
why are we setting this to null here before immediately overriding it with a mock?
There was a problem hiding this comment.
We could remove here. It was just an effort to make sure we first started all tests in a clean slate (ex: this static variable being wiped out), before moving on to additional setup configuration. Went ahead and removed.
tjleing
approved these changes
Jun 9, 2022
sktimalsina
approved these changes
Jun 9, 2022
sdhuka
approved these changes
Jun 9, 2022
div5yesh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 2762 and 2927
Description of changes:
Android 12 introduced the restriction of not allowing the "trampolining" of push notifications from a BroadcastReceiver to an Activity. The proposed solution is moving the trampoline effect from a BroadcastReceiver to an Activity. Google's original intent on the restriction was performance concerns by trampolining, where the user could experience a delay between notification click and app launch. We should ensure PinpointNotificationActivity remains light to keep these concerns to a minimum. An alternative involving backstack manipulation was explored, but this option appears less fragile / more simple.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.