From bc19b5f727362196ddad1968a388e4a922121f03 Mon Sep 17 00:00:00 2001 From: Ichinose Shogo Date: Tue, 18 Aug 2020 23:25:43 +0900 Subject: [PATCH 1/4] introduce reviewdog --- .github/workflows/lint.yml | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 32bb8018..5d36f474 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,25 +1,18 @@ name: tests -on: +on: push: pull_request: jobs: - test: - name: lint + name: lint runs-on: ubuntu-latest steps: - - name: Set up Go 1.13 - uses: actions/setup-go@v1 - with: - go-version: 1.13 - id: go - - name: Check out code into the Go module directory - uses: actions/checkout@v1 - - - name: golangci-golint - run: | - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.27.0 - ./bin/golangci-lint run -v ./... + uses: actions/checkout@v2 + - name: golangci-lint + uses: reviewdog/action-golangci-lint@v1 + with: + level: warning + reporter: github-pr-review From 63d26afcb9e15dd8e4b5f99a69568f9bd8522e0c Mon Sep 17 00:00:00 2001 From: Ichinose Shogo Date: Tue, 18 Aug 2020 23:36:46 +0900 Subject: [PATCH 2/4] remove push trigger --- .github/workflows/lint.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 5d36f474..62e9a697 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,6 +1,5 @@ name: tests on: - push: pull_request: jobs: From 758b1ff1b6ec9a1e4b92d566b97fcc5dde6e70c3 Mon Sep 17 00:00:00 2001 From: Ichinose Shogo Date: Wed, 23 Sep 2020 09:47:51 +0900 Subject: [PATCH 3/4] revert changes of lint.yml --- .github/workflows/lint.yml | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 62e9a697..32bb8018 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,17 +1,25 @@ name: tests -on: +on: + push: pull_request: jobs: + test: - name: lint + name: lint runs-on: ubuntu-latest steps: + - name: Set up Go 1.13 + uses: actions/setup-go@v1 + with: + go-version: 1.13 + id: go + - name: Check out code into the Go module directory - uses: actions/checkout@v2 + uses: actions/checkout@v1 + + - name: golangci-golint + run: | + curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.27.0 + ./bin/golangci-lint run -v ./... - - name: golangci-lint - uses: reviewdog/action-golangci-lint@v1 - with: - level: warning - reporter: github-pr-review From b3a1c8b973ca7ada689c52c2ee67503bbb80fe62 Mon Sep 17 00:00:00 2001 From: Ichinose Shogo Date: Wed, 23 Sep 2020 09:48:02 +0900 Subject: [PATCH 4/4] re-introduce reviewdog --- .github/workflows/reviewdog.yml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .github/workflows/reviewdog.yml diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml new file mode 100644 index 00000000..05944aef --- /dev/null +++ b/.github/workflows/reviewdog.yml @@ -0,0 +1,17 @@ +name: reviewdog +on: + pull_request: + +jobs: + test: + name: lint + runs-on: ubuntu-latest + steps: + - name: Check out code into the Go module directory + uses: actions/checkout@v2 + + - name: golangci-lint + uses: reviewdog/action-golangci-lint@v1 + with: + level: warning + reporter: github-pr-review