Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 1.19 to the unit test matrix #462

Merged
merged 3 commits into from Aug 11, 2022
Merged

add 1.19 to the unit test matrix #462

merged 3 commits into from Aug 11, 2022

Conversation

bmoffatt
Copy link
Collaborator

@bmoffatt bmoffatt commented Aug 10, 2022

Description of changes:

https://go.dev/doc/devel/release#go1.19 released 8/2, should be running tests with it

posting this CR also showed that the listing workflow rotted when latest go became 1.19, so

  • bumped the linter version
  • did a gofmt -s -w **/*.go to appease the new formatter
  • and suppressed the recommendations about the "io/ioutil" rename, since I'm not emotionally ready tonight to drop build support for versions less than go1.16 :)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #462 (69f2b2a) into main (13ee405) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   69.69%   69.69%           
=======================================
  Files          20       20           
  Lines        1201     1201           
=======================================
  Hits          837      837           
  Misses        297      297           
  Partials       67       67           
Impacted Files Coverage Δ
cfn/response.go 69.44% <ø> (ø)
cfn/wrap.go 66.66% <ø> (ø)
cmd/build-lambda-zip/main.go 34.66% <ø> (ø)
events/codebuild.go 40.90% <ø> (ø)
lambda/entry.go 81.81% <ø> (ø)
lambda/extensions_api_client.go 0.00% <ø> (ø)
lambda/handler.go 92.08% <ø> (ø)
lambda/runtime_api_client.go 73.13% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bmoffatt bmoffatt marked this pull request as ready for review August 10, 2022 05:13
@bmoffatt bmoffatt requested a review from carlzogh August 10, 2022 19:49
Copy link
Contributor

@carlzogh carlzogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@carlzogh carlzogh merged commit 4c09e84 into aws:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants