Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark AppSyncResolverTemplate as Deprecated #460

Merged
merged 1 commit into from Jul 27, 2022

Conversation

bmoffatt
Copy link
Collaborator

Issue #, if available:

#150 #344

Description of changes:

#261 removed the README, but the struct was still a discoverable source of confusion. Adding // Deprecated: ... to set off linters, and to annotate on godoc renderers like pkg.go.dev

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bmoffatt bmoffatt marked this pull request as ready for review July 26, 2022 21:50
@bmoffatt bmoffatt requested a review from carlzogh July 26, 2022 21:50
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #460 (7b212a5) into main (6796528) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   72.90%   72.90%           
=======================================
  Files          19       19           
  Lines        1085     1085           
=======================================
  Hits          791      791           
  Misses        225      225           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6796528...7b212a5. Read the comment docs.

@bmoffatt bmoffatt merged commit 151c2c1 into aws:main Jul 27, 2022
@bmoffatt bmoffatt deleted the deprecate-appsync-resolver-struct branch August 21, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants