Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce reviewdog #314

Merged
merged 6 commits into from Dec 22, 2020
Merged

introduce reviewdog #314

merged 6 commits into from Dec 22, 2020

Conversation

shogo82148
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:

golangci-lint is awesome linter, but It takes a lot of work to check the results on pull requests.
reviewdog/action-golangci-lint provides better code review experience.
see reviewdog repo for more info.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2020

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   72.23%   72.23%           
=======================================
  Files          18       18           
  Lines         724      724           
=======================================
  Hits          523      523           
  Misses        136      136           
  Partials       65       65           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b2e41...b3a1c8b. Read the comment docs.

Copy link
Collaborator

@bmoffatt bmoffatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave the lint.yml workflow as-is, and add a new reviewdog.yml to run side-by-side for comparison

@shogo82148
Copy link
Contributor Author

done!
I added reviewdog.yml.

@harrisonhjones
Copy link
Contributor

@bmoffatt any thoughts on this? Seems like a pretty easy win.

@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #314 (2cf8e58) into master (73c2767) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   72.22%   72.22%           
=======================================
  Files          19       19           
  Lines         738      738           
=======================================
  Hits          533      533           
  Misses        138      138           
  Partials       67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73c2767...2cf8e58. Read the comment docs.

@bmoffatt
Copy link
Collaborator

let's see what this looks like!

@bmoffatt bmoffatt merged commit 70e75f4 into aws:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants