New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce reviewdog #314
introduce reviewdog #314
Conversation
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 72.23% 72.23%
=======================================
Files 18 18
Lines 724 724
=======================================
Hits 523 523
Misses 136 136
Partials 65 65 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave the lint.yml
workflow as-is, and add a new reviewdog.yml
to run side-by-side for comparison
done! |
@bmoffatt any thoughts on this? Seems like a pretty easy win. |
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 72.22% 72.22%
=======================================
Files 19 19
Lines 738 738
=======================================
Hits 533 533
Misses 138 138
Partials 67 67 Continue to review full report at Codecov.
|
let's see what this looks like! |
Issue #, if available:
N/A
Description of changes:
golangci-lint is awesome linter, but It takes a lot of work to check the results on pull requests.
reviewdog/action-golangci-lint provides better code review experience.
see reviewdog repo for more info.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.