Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CloudTrail Insights on Trail #8335

Closed
tofijak opened this issue Jun 3, 2020 · 9 comments 路 Fixed by #23099
Closed

Enable CloudTrail Insights on Trail #8335

tofijak opened this issue Jun 3, 2020 · 9 comments 路 Fixed by #23099
Labels
@aws-cdk/aws-cloudtrail Related to AWS CloudTrail effort/small Small work item 鈥撀爈ess than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@tofijak
Copy link

tofijak commented Jun 3, 2020

Enable CloudTrail Insights when creating a Trail.

Proposed Solution

Could be a property of TrailProps.

const trail = new cloudtrail.Trail(this, 'CloudTrail', {
  enableInsights: true
});

This is a 馃殌 Feature Request
@tofijak tofijak added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 3, 2020
@SomayaB SomayaB added the @aws-cdk/aws-cloudtrail Related to AWS CloudTrail label Jun 5, 2020
@rix0rrr rix0rrr added effort/small Small work item 鈥撀爈ess than a day of effort good first issue Related to contributions. See CONTRIBUTING.md labels Jun 8, 2020
@pgollucci
Copy link

This is not yet in CfnTrailProps which is generated

I have it implemented minus that.

@pgollucci
Copy link

It is not yet in the roadmap

https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/projects/1

@andrestone
Copy link
Contributor

AwsCustomResource to the rescue?

@pgollucci
Copy link

I mean you can always do anything that way, but not in the official release........

@andrestone
Copy link
Contributor

I mean you can always do anything that way, but not in the official release........

I actually meant to suggest AwsCustomResource as a way to implement it in the construct library.

@rix0rrr rix0rrr added the p2 label Aug 12, 2020
@SomayaB SomayaB assigned shivlaks and unassigned rix0rrr Aug 20, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Nov 6, 2020
@NGL321 NGL321 assigned nija-at and unassigned shivlaks Jan 25, 2021
@tvb
Copy link

tvb commented Nov 29, 2021

@SomayaB The enableInsights parameter now exists in CloudFormation

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudtrail-trail.html#cfn-cloudtrail-trail-insightselectors

@jej2003
Copy link

jej2003 commented Jun 30, 2022 •
edited

Is this on the roadmap for CDK?

@watany-dev
Copy link
Contributor

I want this feature and will work on it.

@watany-dev watany-dev mentioned this issue Nov 26, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #23099 Dec 7, 2022
mergify bot pushed a commit that referenced this issue Dec 7, 2022
@watany-dev
feat(cloudtrail): enable CloudTrail Insights on Trail (#23099)
8a1460e 
After an issue is submitted, the specification is added and the implementation is such that the InsightType is selected.

fixes #8335 

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

鈿狅笍COMMENT VISIBILITY WARNING鈿狅笍

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

brennanho pushed a commit to brennanho/aws-cdk that referenced this issue Dec 9, 2022
@watany-dev
feat(cloudtrail): enable CloudTrail Insights on Trail (aws#23099)
ecc4b53 
After an issue is submitted, the specification is added and the implementation is such that the InsightType is selected.

fixes aws#8335 

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this issue Jan 20, 2023
@watany-dev
feat(cloudtrail): enable CloudTrail Insights on Trail (aws#23099)
3338ecb 
After an issue is submitted, the specification is added and the implementation is such that the InsightType is selected.

fixes aws#8335 

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this issue Feb 22, 2023
@watany-dev
feat(cloudtrail): enable CloudTrail Insights on Trail (aws#23099)
de2a6d5 
After an issue is submitted, the specification is added and the implementation is such that the InsightType is selected.

fixes aws#8335 

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloudtrail Related to AWS CloudTrail effort/small Small work item 鈥撀爈ess than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudtrail): enable CloudTrail Insights on Trail watany-dev/aws-cdk
10 participants
@pgollucci @rix0rrr @tvb @jej2003 @andrestone @nija-at @SomayaB @tofijak @shivlaks @watany-dev