SecurityGroup: add support for adding Ingress Rules that reference Security Groups from a Peered VPC

[RolandOtta]

Use Case

we have multiple sub accounts that are connected with vpc peering.
we need to manage security-groups that reference security-groups from a peered account like it is possible in cloudformation with
SourceSecurityGroupOwnerId and
SourceSecurityGroupId in the AWS::EC2::SecurityGroup

from what i have seen so far this is not possible with the addIngressRule method of the ec2 securitygroup

Proposed Solution

Other

• 👋 I may be able to implement this feature request
• ⚠️ This feature might incur a breaking change

---

This is a 🚀 Feature Request

[rix0rrr]

This needs an additional implementation of IPeer.

[singlewind]

Can write like this

const incomingSecurityGroup = new SecurityGroup(
      this,
      "IncomingSecurityGroup",
      {
        vpc: imports.vpc,
        allowAllOutbound: true,
      }
    );

incomingSecurityGroup.addIngressRule(incomingSecurityGroup, Port.tcp(props.lokiHttpPort), 'Internal HTTP');
incomingSecurityGroup.addIngressRule(incomingSecurityGroup, Port.tcp(props.lokiGrpcPort), 'Internal GRPC');
incomingSecurityGroup.addIngressRule(incomingSecurityGroup, Port.tcp(props.lokiMemberlistPort), 'Internal Memberlist');

[dev-d]

Not sure how @singlewind 's solution solves the problem.

Tried using ec2.CfnSecurityGroupIngress - in theory it should work, but It did not.

[mikeatlas]

@dev-d Any luck since posting?
@rix0rrr I might be up for making said IPeer implementation PR...

[singlewind]

Not sure how @singlewind 's solution solves the problem.

Tried using ec2.CfnSecurityGroupIngress - in theory it should work, but It did not.

Sorry, I misunderstood the problem.

[therealvio]

Any updates on this?

Connecting vpc-peered security groups is something we are looking to do too :)

[BDeus]

maybe it can be closed, because there are an implementation of Peer SG with another account ?
Peer.securityGroupId(sgId, accoungId)

[MrArnoldPalmer]

This was solved by #18248, reopen if you're still having an issue. Thanks

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.