Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff: Improve diff of IAM policies #43

Closed
eladb opened this issue Jun 5, 2018 · 5 comments
Closed

diff: Improve diff of IAM policies #43

eladb opened this issue Jun 5, 2018 · 5 comments
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management effort/medium Medium work item – several days of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2

Comments

@eladb
Copy link
Contributor

eladb commented Jun 5, 2018

This doesn't really help out, especially when column-wrapped in the console:

[~] 🛠 Updating ReleaseReleaseProjectRoleDefaultPolicy84BD3DD4 (type: AWS::IAM::Policy)
 └─ [~] .PolicyDocument:
     └─ [~] .Statement:
         ├─ [-] Old value: [{"Action":["logs:CreateLogGroup","logs:CreateLogStream","logs:PutLogEvents"],"Effect":"Allow","Resource":
[{"Fn::Join":["",["arn",":",{"Ref":"AWS::Partition"},":","logs",":",{"Ref":"AWS::Region"},":",
{"Ref":"AWS::AccountId"},":","log-group",":",{"Fn::Join":["",["/aws/codebuild/",
{"Ref":"ReleaseReleaseProject7FF55BD1"}]]}]]},{"Fn::Join":["",[{"Fn::Join":["",["arn",":",
{"Ref":"AWS::Partition"},":","logs",":",{"Ref":"AWS::Region"},":",{"Ref":"AWS::AccountId"},":","log-
group",":",{"Fn::Join":["",["/aws/codebuild/",{"Ref":"ReleaseReleaseProject7FF55BD1"}]]}]]},":*"]]}]},
{"Action":
["s3:GetObject*","s3:GetBucket*","s3:List*","s3:PutObject*","s3:DeleteObject*","s3:Abort*"],"Effect":"A
llow","Resource":[{"Fn::GetAtt":["BuildPipelineArtifactsBucket6007E7FC","Arn"]},{"Fn::Join":["",
[{"Fn::GetAtt":["BuildPipelineArtifactsBucket6007E7FC","Arn"]},"/","*"]]}]},{"Action":
["s3:GetObject*","s3:GetBucket*","s3:List*","s3:PutObject*","s3:DeleteObject*","s3:Abort*"],"Effect":"A
llow","Resource":[{"Fn::GetAtt":["ReleasesCA994599","Arn"]},{"Fn::Join":["",[{"Fn::GetAtt":
["ReleasesCA994599","Arn"]},"/","*"]]}]},{"Action":"ses:SendEmail","Effect":"Allow","Resource":
{"Fn::Join":["",["arn",":",{"Ref":"AWS::Partition"},":","ses",":",{"Ref":"AWS::Region"},":",
{"Ref":"AWS::AccountId"},":","identity","/","foo@bar"]]}}]
         └─ [+] New value: [{"Action":
["logs:CreateLogGroup","logs:CreateLogStream","logs:PutLogEvents"],"Effect":"Allow","Resource":
[{"Fn::Join":["",["arn",":",{"Ref":"AWS::Partition"},":","logs",":",{"Ref":"AWS::Region"},":",{"Ref":"AWS::AccountId"},":","log-group",":",{"Fn::Join":["",["/aws/codebuild/",
{"Ref":"ReleaseReleaseProject7FF55BD1"}]]}]]},{"Fn::Join":["",[{"Fn::Join":["",["arn",":",
{"Ref":"AWS::Partition"},":","logs",":",{"Ref":"AWS::Region"},":",{"Ref":"AWS::AccountId"},":","log-
group",":",{"Fn::Join":["",["/aws/codebuild/",{"Ref":"ReleaseReleaseProject7FF55BD1"}]]}]]},":*"]]}]},
{"Action":
["s3:GetObject*","s3:GetBucket*","s3:List*","s3:PutObject*","s3:DeleteObject*","s3:Abort*"],"Effect":"A
llow","Resource":[{"Fn::GetAtt":["BuildPipelineArtifactsBucket6007E7FC","Arn"]},{"Fn::Join":["",
[{"Fn::GetAtt":["BuildPipelineArtifactsBucket6007E7FC","Arn"]},"/","*"]]}]},{"Action":
["s3:GetObject*","s3:GetBucket*","s3:List*","s3:PutObject*","s3:DeleteObject*","s3:Abort*"],"Effect":"A
llow","Resource":[{"Fn::GetAtt":["ReleasesCA994599","Arn"]},{"Fn::Join":["",[{"Fn::GetAtt":
["ReleasesCA994599","Arn"]},"/","*"]]}]},{"Action":"ses:SendEmail","Effect":"Allow","Resource":
{"Fn::Join":["",["arn",":",{"Ref":"AWS::Partition"},":","ses",":",{"Ref":"AWS::Region"},":",
{"Ref":"AWS::AccountId"},":","identity","/","foo@zar"]]}}]
@debora-ito debora-ito added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Nov 7, 2018
@SomayaB SomayaB added the feature-request A feature should be added or improved. label Sep 24, 2019
@rix0rrr rix0rrr added the effort/medium Medium work item – several days of effort label Jan 23, 2020
@rix0rrr rix0rrr added the p2 label Aug 12, 2020
@ericzbeard
Copy link
Contributor

@rix0rrr this is done, isn't it?

@ericzbeard ericzbeard added the feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. label Apr 6, 2021
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@peterwoodworth
Copy link
Contributor

Think it's safe to say this issue can be closed out with the recent IAM policy optimizations implemented 🙂

1 similar comment
@peterwoodworth
Copy link
Contributor

Think it's safe to say this issue can be closed out with the recent IAM policy optimizations implemented 🙂

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management effort/medium Medium work item – several days of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

6 participants