Skip to content

(core): Build script does not recognize dotnet >= 6 #24466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markusl opened this issue Mar 6, 2023 · 2 comments · Fixed by #24467
Closed

(core): Build script does not recognize dotnet >= 6 #24466

markusl opened this issue Mar 6, 2023 · 2 comments · Fixed by #24467
Labels
@aws-cdk/core Related to core CDK functionality bug This issue is a bug. effort/small Small work item – less than a day of effort

Comments

@markusl
Copy link
Contributor

markusl commented Mar 6, 2023

Describe the bug

Running yarn build does not succeed if dotnet 7 is installed.

Expected Behavior

dotnet 7, which is Microsoft recommendation, should be recognized properly.

Current Behavior

Checking dotnet version... Found dotnet version 7.0.102 [/usr/local/share/dotnet/x64/sdk]. Install dotnet >= 6.0.100

Reproduction Steps

Install recommended .NET 7.0 version from https://dotnet.microsoft.com/en-us/download

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.66.1 (build 539d036)

Framework Version

No response

Node.js Version

v18.12.1

OS

macOS

Language

Typescript

Language Version

No response

Other information

No response
@markusl markusl added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 6, 2023
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Mar 6, 2023
@markusl markusl mentioned this issue Mar 6, 2023
Merged
@pahud
Copy link
Contributor

pahud commented Mar 6, 2023

Thank you for the call out and the PR! I think it makes sense here.

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed p2 needs-triage This issue or PR still needs to be triaged. labels Mar 6, 2023
@mergify mergify bot closed this as completed in #24467 Mar 6, 2023
mergify bot pushed a commit that referenced this issue Mar 6, 2023
@markusl
fix(core): Fix dotnet version check to allow .NET 7.0 (#24467)
a4856e9 
Fix dotnet version check to allow .NET 7.0

Closes #24466.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

homakk pushed a commit to homakk/aws-cdk that referenced this issue Mar 28, 2023
@markusl @homakk
fix(core): Fix dotnet version check to allow .NET 7.0 (aws#24467)
5443d97 
Fix dotnet version check to allow .NET 7.0

Closes aws#24466.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/core Related to core CDK functionality bug This issue is a bug. effort/small Small work item – less than a day of effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): Fix dotnet version check to allow .NET 7.0
2 participants
@pahud @markusl