(timestream): retentionProperties as Json is not working anymore

[Wurstnase]

Describe the bug

With 2.55.0 the cfnspec changes.

3951f09#diff-0d394a72825e270916f40b00a99f6e46b17ad80d4a4c76d19dd1688883a0f96cR451
3951f09#diff-0d394a72825e270916f40b00a99f6e46b17ad80d4a4c76d19dd1688883a0f96cR457

      "MagneticStoreWriteProperties": {
          "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-timestream-table.html#cfn-timestream-table-magneticstorewriteproperties",
-         "PrimitiveType": "Json",
          "Required": false,
+         "Type": "MagneticStoreWriteProperties",
          "UpdateType": "Mutable"
        },
        "RetentionProperties": {
          "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-timestream-table.html#cfn-timestream-table-retentionproperties",
-          "PrimitiveType": "Json",
          "Required": false,
+          "Type": "RetentionProperties",
          "UpdateType": "Mutable"
        },

At least with python, when you define the structure as a python-dict, the properties are missing in the cloudformation template.

        timestream.CfnTable(
            self,
            "Table",
            database_name=cfn_database.ref,
            table_name=TABLE_NAME,
-            retention_properties={
-                "MagneticStoreRetentionPeriodInDays": magnetic_store_retention_period_in_days,
-                "MemoryStoreRetentionPeriodInHours": memory_store_retention_period_in_hours,
+            retention_properties=timestream.CfnTable.RetentionPropertiesProperty(
+                magnetic_store_retention_period_in_days=str(magnetic_store_retention_period_in_days),
+                memory_store_retention_period_in_hours=str(memory_store_retention_period_in_hours),
            ),
        )

Expected Behavior

Defining the properties as a python-dict should synth the properties into the cloudformation stack.

Current Behavior

When defining the properties as a dict, the cloudformation stack has not properties.

Reproduction Steps

see python example above.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.55.1

Framework Version

No response

Node.js Version

OS

Language

Python

Language Version

3.9.16

Other information

No response

[peterwoodworth]

I'm sorry this regression occurred @Wurstnase, we try to avoid merging spec changes which will cause regressions for customers. Thank you for letting us know this happened 🙂

[Wurstnase]

Thanks for your quick response. Fortunately, we have snapshot tests for our stacks.

The most annoying thing about this error is that it is silent. Not an error. It just disappears. Maybe there is an idea that this could lead to an exception?

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[madeline-k]

Hey @Wurstnase, this has been fixed and released in version 2.56.0! We are keeping track of occurrences like this in this issue: #21767, and solutions/suggestions for this problem should go there. I like your suggestion of having an error message. It might be tricky to do since this manifests slightly differently in each target language.