New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_apigateway: unable to add multi-level base path mappings #23347
Labels
@aws-cdk/aws-apigateway
Related to Amazon API Gateway
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
Comments
VarunWachaspati
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Dec 14, 2022
github-actions
bot
added
the
@aws-cdk/aws-apigateway
Related to Amazon API Gateway
label
Dec 14, 2022
Also, if possible can anyone suggest a work around for this issue in the meanwhile. Would greatly appreciate it. |
4 tasks
mergify bot
pushed a commit
that referenced
this issue
Dec 17, 2022
API Gateway allows multi-level base path mapping but CDK doesn't support the same yet. ([AWS Announcement Post](https://aws.amazon.com/about-aws/whats-new/2021/03/amazon-api-gateway-custom-domain-names-support-multi-level-base-path-mappings/)) Also, added new base path mapping validations such as shouldn't start or end with `/` or shouldn't contain consecutive `/`. fixes #23347 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Construct Runtime Dependencies: * [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this issue
Jan 20, 2023
API Gateway allows multi-level base path mapping but CDK doesn't support the same yet. ([AWS Announcement Post](https://aws.amazon.com/about-aws/whats-new/2021/03/amazon-api-gateway-custom-domain-names-support-multi-level-base-path-mappings/)) Also, added new base path mapping validations such as shouldn't start or end with `/` or shouldn't contain consecutive `/`. fixes aws#23347 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Construct Runtime Dependencies: * [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this issue
Feb 22, 2023
API Gateway allows multi-level base path mapping but CDK doesn't support the same yet. ([AWS Announcement Post](https://aws.amazon.com/about-aws/whats-new/2021/03/amazon-api-gateway-custom-domain-names-support-multi-level-base-path-mappings/)) Also, added new base path mapping validations such as shouldn't start or end with `/` or shouldn't contain consecutive `/`. fixes aws#23347 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Construct Runtime Dependencies: * [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-apigateway
Related to Amazon API Gateway
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
Describe the bug
As per this AWS announcement post, API Gateway support multi-level path mappings like
api/v2/action
orapi/example-api
now.Now when I try to add a base path mapping containing a slash(/) via CDK it throws an error even though the same can be achieved via the AWS console successfully.
Expected Behavior
Should be able to add multi-level base path mappings containing slashes(/) via CDK.
Current Behavior
Throws the following error when you try to add multi-level base path mapping in API Gateway -
Reproduction Steps
Sample CDK code to reproduce the issue -
Possible Solution
Modify the following validation to accommodate slash(/) -
aws-cdk/packages/@aws-cdk/aws-apigateway/lib/base-path-mapping.ts
Lines 58 to 62 in 30301d9
I can contribute to fix this issue if the above proposed solution is acceptable.
Additional Information/Context
No response
CDK CLI Version
2.46.0
Framework Version
No response
Node.js Version
14.17.1
OS
MacOS Monterey 12.5
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: