Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): typescript init templates fail with error in build step #23130

Merged
merged 1 commit into from Nov 29, 2022

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 28, 2022

Fixes the compile error when running cdk init app --language typescript && npm run build.

Fixes: #23126 for v1


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 28, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team November 28, 2022 23:46
@mrgrain mrgrain added pr/do-not-merge This PR should not be merged at this time. pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed p2 labels Nov 28, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 28, 2022
@mrgrain mrgrain force-pushed the mrgrain/fix/v1/pin-@types/babel__traverse-version branch from ebaa91d to 10a2715 Compare November 28, 2022 23:49
@gitpod-io
Copy link

gitpod-io bot commented Nov 28, 2022

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 10a2715
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mrgrain mrgrain added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/do-not-merge This PR should not be merged at this time. labels Nov 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b06cd20 into v1-main Nov 29, 2022
@mergify mergify bot deleted the mrgrain/fix/v1/pin-@types/babel__traverse-version branch November 29, 2022 02:42
mrgrain added a commit that referenced this pull request Nov 29, 2022
…3130)

Fixes the compile error when running `cdk init app --language typescript && npm run build`.

Fixes: #23126 for v1

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants