feat(cloudtrail): enable CloudTrail Insights on Trail #23099
Conversation
|
|
github-actions
bot
added
effort/small
watany-dev
force-pushed
the
trail-insight
branch
from
6adcf67
to
d2f6a01
Compare
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
I believe the following is relevant to the changes here. |
|
Hmmm, this error may not be immediately obvious because the integtest I have modified is not a relative path specification as shown below. Suspicious part is aws-cdk-lib instead of @aws-cdk-lib? |
Integration tests with the
or
|
|
I am very pleased with your kind response. I will try the former method to resolve this. |
mrgrain
changed the title
| /** | ||
| * Util element for InsightSelector | ||
| */ | ||
| export class InsightType { |
There was a problem hiding this comment.
[non-blocking] What are the reasons to use a class instead of an enum here?
There was a problem hiding this comment.
My apologies. I'm just left with something that was created with expandability in mind during development.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
After an issue is submitted, the specification is added and the implementation is such that the InsightType is selected. fixes aws#8335 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
After an issue is submitted, the specification is added and the implementation is such that the InsightType is selected. fixes aws#8335 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
After an issue is submitted, the specification is added and the implementation is such that the InsightType is selected. fixes aws#8335 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
After an issue is submitted, the specification is added and the implementation is such that the InsightType is selected.
fixes #8335
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license