Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Add progress info to CDK deploy command #22879

Closed
1 of 2 tasks
AlexGurtoff opened this issue Nov 11, 2022 · 2 comments · Fixed by #22883
Closed
1 of 2 tasks

CLI: Add progress info to CDK deploy command #22879

AlexGurtoff opened this issue Nov 11, 2022 · 2 comments · Fixed by #22883
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@AlexGurtoff
Copy link
Contributor

AlexGurtoff commented Nov 11, 2022 •
edited

Describe the feature

Add place in the order of the stack that’s currently being deployed, like StackName Deploying... [4/45] to cdk deploy command

Use Case

Currently, this is hard to define how many stacks remain to the app will be fully deployed. For example, we have more than 50 stacks in our app, and the deployment process takes 60-180 minutes, so, if you don't remember the exactly deploy order of CDK it is impossible to know how many stacks are left to estimate the remaining time properly

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.50.0

Environment details (OS name and version, etc.)

MacOs 12.4
@AlexGurtoff AlexGurtoff added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 11, 2022
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Nov 11, 2022
@AlexGurtoff AlexGurtoff changed the title CLI: Add deploy stack order and progress info to CDK logs CLI: Add progress info to CDK logs Nov 11, 2022
@AlexGurtoff AlexGurtoff changed the title CLI: Add progress info to CDK logs CLI: Add progress info to CDK deploy command Nov 11, 2022
@AlexGurtoff AlexGurtoff mentioned this issue Nov 11, 2022
Merged
4 tasks
@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 11, 2022
@peterwoodworth
Copy link
Contributor

Thanks for the FR and PR @AlexGurtoff, it's always nice to make things more clear in the CLI 🙂 We will try to take a look at the PR when we can!

@mergify mergify bot closed this as completed in #22883 Dec 5, 2022
mergify bot pushed a commit that referenced this issue Dec 5, 2022
@AlexGurtoff
feat(cli): show stack progress info in cdk deploy/destroy commands (#…
62c82d7 
…22883)

closes #22879

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?


*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

brennanho pushed a commit to brennanho/aws-cdk that referenced this issue Dec 9, 2022
@AlexGurtoff
feat(cli): show stack progress info in cdk deploy/destroy commands (a…
9e7c805 
…ws#22883)

closes aws#22879

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?


*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this issue Jan 20, 2023
@AlexGurtoff
feat(cli): show stack progress info in cdk deploy/destroy commands (a…
b0585f4 
…ws#22883)

closes aws#22879

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?


*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this issue Feb 22, 2023
@AlexGurtoff
feat(cli): show stack progress info in cdk deploy/destroy commands (a…
2808882 
…ws#22883)

closes aws#22879

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?


*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): show stack progress info in cdk deploy/destroy commands AlexGurtoff/aws-cdk
3 participants
@rix0rrr @AlexGurtoff @peterwoodworth