Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): kubectl get handler output includes stderr #22658

Merged
merged 16 commits into from Oct 27, 2022
Merged

fix(eks): kubectl get handler output includes stderr #22658

merged 16 commits into from Oct 27, 2022

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Oct 26, 2022

The custom resource that handles kubectl requests returns standard output and standard error in the same string. This is normally okay, because we likely get either a successful result with standard output, or an unsuccessful one with standard error. However, there are certain circumstances where kubectl returns a successful result with standard output as well as warnings in standard error. These warnings are harmless, but because of how the custom resource is set up, it corrupts the output that gets returned. This results in integ test failure.

These changes separate out standard output and standard error that gets returned by kubectl, and only prints the error if we mean to throw an error.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 26, 2022

@github-actions github-actions bot added the p2 label Oct 26, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team October 26, 2022 18:53
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 26, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 26, 2022 22:51

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still integration tests in step-functions whose snapshots were changed by this PR. Ideally we would not have to re-deploy this. Files names for nested stack templates where the only changes in those templates were asset hashes should also get ignored. But we don't have this functionality in the integ runner yet.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: af3362c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 66d1ed3 into main Oct 27, 2022
@mergify mergify bot deleted the conroy/eks branch October 27, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants