docs(ecs): fixes rosetta extraction errors in the README file #22646
Conversation
|
|
github-actions
bot
added
repeat-contributor
| @@ -1,6 +1,6 @@ | |||
| // Fixture with packages imported, but nothing else | |||
| import { Construct } from 'constructs'; | |||
| import { SecretValue, Stack } from '@aws-cdk/core'; | |||
| import * as cdkCore from '@aws-cdk/core'; | |||
There was a problem hiding this comment.
This won't translate to V2 properly, I don't think, so this line shouldn't be changed.
There was a problem hiding this comment.
I see - I can revert that.
The only thing I need here is Size 😅 I was trying to make it clearer that it comes from the core package.
mergify
bot
dismissed
TheRealAmazonKendra’s stale review
Pull request has been modified.
TheRealAmazonKendra
changed the title
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
When running
yarn rosetta:extract --strictin@aws-cdk/aws-ecspackage, there are various errors:This PR fixes all that so the command works.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license