Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoscaling): support for throughput on GP3 volumes #22441

Merged
merged 8 commits into from Nov 25, 2022

Conversation

csumpter
Copy link
Contributor

@csumpter csumpter commented Oct 10, 2022

Adds support for the throughput property on GP3 volumes in both autoscaling and EC2 packages since their volume implementations are separate per the comment https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/aws-autoscaling/lib/volume.ts#L1.

Change includes unit test coverage, integration test coverage on the autoscaling changes, and validation of the inputq to throughput. I was on the fence about whether to include the validation for synth time checking since as far as I can tell validation is not performed consistently across the CDK at synth time. Happy to modify that behavior pending reviewer feedback.

It was not obvious to me at first pass where similar integration test coverage that was added to the autoscaling package could be added to the EC2 package, so if the reviewer would like to see integration tests for GP3 volumes on in the EC2 package, would you mind providing a hint as to where that test might fit in the existing test paradigm?

Happy to break this change into two PRs -- one for EC2 and one for autoscaling.

closes: #16213


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 10, 2022

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Oct 10, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team October 10, 2022 12:13
@github-actions github-actions bot added the p2 label Oct 10, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@csumpter csumpter changed the title feat(autoscaling/ec2): adds support for throughput on GP3 volumes feat(aws-autoscaling): adds support for throughput on GP3 volumes Oct 10, 2022
@csumpter csumpter force-pushed the csumpter/asg-ebs-throughput branch 2 times, most recently from db11b67 to 78ef388 Compare October 10, 2022 12:45
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 10, 2022 12:45

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@corymhall corymhall added p1 and removed p2 labels Oct 18, 2022
@corymhall corymhall self-assigned this Oct 21, 2022
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@corymhall corymhall removed their assignment Nov 2, 2022
@mergify mergify bot dismissed corymhall’s stale review November 3, 2022 02:35

Pull request has been modified.

@csumpter
Copy link
Contributor Author

Hello aws-cdk team! This PR is ready for review at your leisure. Please let me know if there are any additional updates you would like to see. Thank you!

@mrgrain mrgrain changed the title feat(aws-autoscaling): adds support for throughput on GP3 volumes feat(autoscaling): adds support for throughput on GP3 volumes Nov 25, 2022
@mrgrain mrgrain changed the title feat(autoscaling): adds support for throughput on GP3 volumes feat(autoscaling): support for throughput on GP3 volumes Nov 25, 2022
mrgrain
mrgrain previously approved these changes Nov 25, 2022
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good now! 🚀

Thanks for the contribution @csumpter

@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed mrgrain’s stale review November 25, 2022 15:34

Pull request has been modified.

@mrgrain mrgrain self-requested a review November 25, 2022 16:19
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9ffd0da
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d13b64a into aws:main Nov 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ec2): support throughput option in EBS volume
4 participants