Closed
Description
Describe the bug
While creating the SAML federation principal as below, the SAML attribute is hardcoded with https://signin.aws.amazon.com/saml
, which breaks in aws-cn
partition since the SAML attribute should be changed to https://signin.amazonaws.cn/saml
in AWS CN partition.
const principal = new iam.SamlConsolePrincipal(provider);
Expected Behavior
The construct SamlConsolePrincipal
should allow to customize the SAML attribute for this case. This could be an option to change it.
Current Behavior
Currently it's hardcoded and can't be customized while using the construct.
Reproduction Steps
const principal = new iam.SamlConsolePrincipal(provider);
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.39.0
Framework Version
No response
Node.js Version
v16.16.0
OS
Mac
Language
Typescript
Language Version
No response
Other information
No response
Activity
[-](aws_cdk/aws_iam): (Hardcoded SAML attribute breaks aws-cn partition for SamlConsolePrincipal)[/-][+]iam: SamlConsolePrincipal does not work in China[/+]rix0rrr commentedon Sep 19, 2022
Looks like this information needs to be encoded into
region-info
.fix iam: SamlConsolePrincipal does not work in China aws#22091
fix(iam): SamlConsolePrincipal does not work in China #22091 (#24034)
github-actions commentedon Feb 10, 2023
Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.
2 remaining items