Skip to content

iam: SamlConsolePrincipal does not work in China #22091

Closed
@ganhuang

Description

@ganhuang

Describe the bug

While creating the SAML federation principal as below, the SAML attribute is hardcoded with https://signin.aws.amazon.com/saml, which breaks in aws-cn partition since the SAML attribute should be changed to https://signin.amazonaws.cn/saml in AWS CN partition.

  const principal = new iam.SamlConsolePrincipal(provider);

Expected Behavior

The construct SamlConsolePrincipal should allow to customize the SAML attribute for this case. This could be an option to change it.

Current Behavior

Currently it's hardcoded and can't be customized while using the construct.

Reproduction Steps

  const principal = new iam.SamlConsolePrincipal(provider);

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.39.0

Framework Version

No response

Node.js Version

v16.16.0

OS

Mac

Language

Typescript

Language Version

No response

Other information

No response

Activity

added
bugThis issue is a bug.
needs-triageThis issue or PR still needs to be triaged.
on Sep 17, 2022
changed the title [-](aws_cdk/aws_iam): (Hardcoded SAML attribute breaks aws-cn partition for SamlConsolePrincipal)[/-] [+]iam: SamlConsolePrincipal does not work in China[/+] on Sep 19, 2022
rix0rrr

rix0rrr commented on Sep 19, 2022

@rix0rrr
Contributor

Looks like this information needs to be encoded into region-info.

added
effort/smallSmall work item – less than a day of effort
and removed
needs-triageThis issue or PR still needs to be triaged.
on Sep 19, 2022
removed their assignment
on Sep 19, 2022
github-actions

github-actions commented on Feb 10, 2023

@github-actions
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

2 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    @aws-cdk/aws-iamRelated to AWS Identity and Access ManagementbugThis issue is a bug.effort/smallSmall work item – less than a day of effortp1

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @rix0rrr@ganhuang

      Issue actions

        iam: SamlConsolePrincipal does not work in China · Issue #22091 · aws/aws-cdk