Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-stepfunctions): Add missing intrinsic function States.JsonMerge #22068

Closed
2 tasks
gkkachi opened this issue Sep 16, 2022 · 2 comments · Fixed by #22431
Closed
2 tasks

(aws-stepfunctions): Add missing intrinsic function States.JsonMerge #22068

gkkachi opened this issue Sep 16, 2022 · 2 comments · Fixed by #22431
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@gkkachi
Copy link
Contributor

gkkachi commented Sep 16, 2022 •
edited

Describe the feature

Support for the intrinsic function States.JsonMerge .
AWS Documentation: https://docs.amazonaws.cn/en_us/step-functions/latest/dg/amazon-states-language-intrinsic-functions.html#asl-intrsc-func-json-manipulate

Use Case

Obvious

Proposed Solution

Add JsonPath.jsonMerge() here:
https://github.com/aws/aws-cdk/blob/main/packages/@aws-cdk/aws-stepfunctions/lib/fields.ts

Other Information

We could use States.JsonMerge like below, but syntax check fails when running cdk deploy .
We have to change some code to make it passed.

TaskInput.fromJsonPathAt('States.JsonMerge($.json1, $.json2, false)')

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.41.0

Environment details (OS name and version, etc.)

macOS Big Sur 11.5
@gkkachi gkkachi added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 16, 2022
@github-actions github-actions bot added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Sep 16, 2022
@kaizencc kaizencc added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Sep 19, 2022
@kaizencc kaizencc removed their assignment Sep 19, 2022
@kaizencc
Copy link
Contributor

Hi @gkkachi, would be happy to accept a contribution for this. Labeling as p2 just because we probably don't have bandwidth to pick this up right now, but would be happy to review a community contribution.

@gkkachi gkkachi mentioned this issue Oct 9, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #22431 Oct 31, 2022
mergify bot pushed a commit that referenced this issue Oct 31, 2022
@gkkachi
feat(stepfunctions): add intrinsic functions (#22431)
8f85b08 
Resolves #22068 and resolves #22629

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(stepfunctions): add intrinsic functions gkkachi/aws-cdk
2 participants
@gkkachi @kaizencc