fix: integration test for appsync apikey auth fails with out of bound API key expiration #21198
+11
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mrgrain
force-pushed
the
fix/aws-appsync/integ/auth-apikey
branch
from
e592fb1 to
0e23c5a
Compare
mrgrain
changed the title
otaviomacedo
approved these changes
Jul 18, 2022
…ound API key expiration The test case used an explicit expiration date, causing all PR builds to fail. Explicitly setting the property to `undefined` so the snapshot will be deterministic.
mrgrain
force-pushed
the
fix/aws-appsync/integ/auth-apikey
branch
from
0e23c5a to
aaca1d9
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
https://github.com/Mergifyio backport v1-main |
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2022
… API key expiration (#21198) The test case used an explicit expiration date, causing all PR builds to fail. Changing this to a dynamic duration so we don't have to update this in future. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit 37a44d7) # Conflicts: # packages/@aws-cdk/aws-appsync/test/auth-apikey.integ.snapshot/aws-appsync-integ.assets.json # packages/@aws-cdk/aws-appsync/test/auth-apikey.integ.snapshot/tree.json
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Jul 18, 2022
… API key expiration (backport #21198) (#21204) This is an automatic backport of pull request #21198 done by [Mergify](https://mergify.com). Cherry-pick of 37a44d7 has failed: ``` On branch mergify/bp/v1-main/pr-21198 Your branch is up to date with 'origin/v1-main'. You are currently cherry-picking commit 37a44d7. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: packages/@aws-cdk/aws-appsync/test/auth-apikey.integ.snapshot/aws-appsync-integ.template.json modified: packages/@aws-cdk/aws-appsync/test/auth-apikey.integ.snapshot/cdk.out modified: packages/@aws-cdk/aws-appsync/test/auth-apikey.integ.snapshot/manifest.json modified: packages/@aws-cdk/aws-appsync/test/integ.auth-apikey.ts Unmerged paths: (use "git add/rm <file>..." as appropriate to mark resolution) deleted by us: packages/@aws-cdk/aws-appsync/test/auth-apikey.integ.snapshot/aws-appsync-integ.assets.json both modified: packages/@aws-cdk/aws-appsync/test/auth-apikey.integ.snapshot/tree.json ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
comcalvi
pushed a commit
to comcalvi/aws-cdk
that referenced
this pull request
Jul 25, 2022
… API key expiration (aws#21198) The test case used an explicit expiration date, causing all PR builds to fail. Changing this to a dynamic duration so we don't have to update this in future. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case used an explicit expiration date, causing all PR builds to fail.
Changing this to a dynamic duration so we don't have to update this in future.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license