Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secretsmanager): secret rotation uses old application versions #19490

Merged
merged 3 commits into from Mar 21, 2022

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Mar 21, 2022

Closes #19487


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 21, 2022

@github-actions github-actions bot added the @aws-cdk/aws-secretsmanager Related to AWS Secrets Manager label Mar 21, 2022
rix0rrr
rix0rrr previously approved these changes Mar 21, 2022
@mergify mergify bot dismissed rix0rrr’s stale review March 21, 2022 13:11

Pull request has been modified.

@jogold jogold requested a review from rix0rrr March 21, 2022 13:14
@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0c983ad into aws:master Mar 21, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jogold jogold deleted the update-secret-rotation-apps branch March 21, 2022 17:00
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 19922d2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-secretsmanager Related to AWS Secrets Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-rds): adding secret rotation via SAM application fails
4 participants