Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(synthetics): Add new runtime with Puppeteer 3.4 #19382

Closed
2 tasks
kornicameister opened this issue Mar 14, 2022 · 2 comments · Fixed by #19429
Closed
2 tasks

(synthetics): Add new runtime with Puppeteer 3.4 #19382

kornicameister opened this issue Mar 14, 2022 · 2 comments · Fixed by #19429
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@kornicameister
Copy link
Contributor

kornicameister commented Mar 14, 2022 •
edited

Description

image

Use Case

Ability to upgrade canaries to newest runtime ;-)

Proposed Solution

Add new constant here called SYNTHETICS_NODEJS_PUPPETEER_3_4 with value new Runtime('syn-nodejs-puppeteer-3.4', RuntimeFamily.NODEJS);

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@kornicameister kornicameister added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 14, 2022
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Mar 14, 2022
@kaizencc kaizencc added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 14, 2022
@kaizencc kaizencc removed their assignment Mar 14, 2022
@kaizencc kaizencc added the good first issue Related to contributions. See CONTRIBUTING.md label Mar 14, 2022
@kaizencc kaizencc changed the title (canary): Add new runtime with Puppeteer 3.4 (synthetics): Add new runtime with Puppeteer 3.4 Mar 14, 2022
ktheory added a commit to ktheory/aws-cdk that referenced this issue Mar 17, 2022
@ktheory
feat(synthetics): add support for puppeteer 3.4 runtime
49734ee 
Fixes aws#19382
ktheory added a commit to ktheory/aws-cdk that referenced this issue Mar 17, 2022
@ktheory
feat(synthetics): add support for puppeteer 3.4 runtime
680f74c 
Fixes aws#19382
@ktheory ktheory mentioned this issue Mar 17, 2022
Merged
@mergify mergify bot closed this as completed in #19429 Mar 18, 2022
mergify bot pushed a commit that referenced this issue Mar 18, 2022
@ktheory
feat(synthetics): add support for puppeteer 3.4 runtime (#19429)
024b890 
Fixes #19382


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

iliapolo pushed a commit that referenced this issue Mar 20, 2022
@ktheory @iliapolo
feat(synthetics): add support for puppeteer 3.4 runtime (#19429)
df36827 
Fixes #19382


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@kornicameister
Copy link
Contributor Author

heh, there's already 3.5 -> #19634 🗡️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(synthetics): add support for puppeteer 3.4 runtime ktheory/aws-cdk
2 participants
@kornicameister @kaizencc