Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipelines): add variable namespace support for CodeBuildStep #18893

Closed
wants to merge 1 commit into from
Closed

feat(pipelines): add variable namespace support for CodeBuildStep #18893

wants to merge 1 commit into from

Conversation

markusl
Copy link
Contributor

@markusl markusl commented Feb 9, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 9, 2022

@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Feb 9, 2022
@markusl markusl mentioned this pull request Feb 9, 2022
Closed
@markusl
Copy link
Contributor Author

markusl commented Feb 9, 2022

@skinny85 @rix0rrr any comments on the implementation? Is there something missing to be able to merge this change?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 89a2d32
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rix0rrr added a commit that referenced this pull request Feb 17, 2022
@rix0rrr
Squashed commit of the following:
9b0efeb 
feat(pipelines): step outputs

Make it possible to export environment variables from a CodeBuildStep,
and pipeline sources, and use them in the environment variables of
a CodeBuildStep or ShellStep.

Closes #17189, closes #18893, closes #15943, closes #16407.
@rix0rrr rix0rrr mentioned this pull request Feb 17, 2022
Merged
@markusl
Copy link
Contributor Author

markusl commented Feb 18, 2022

Another implementation available at #19024

@markusl markusl closed this Feb 18, 2022
@markusl markusl deleted the support-variable-namespace branch February 18, 2022 08:59
mergify bot pushed a commit that referenced this pull request Feb 23, 2022
@rix0rrr
feat(pipelines): step outputs (#19024)
0dec2ee 
Make it possible to export environment variables from a CodeBuildStep,
and pipeline sources, and use them in the environment variables of
a CodeBuildStep or ShellStep.

Closes #17189, closes #18893, closes #15943, closes #16407.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/pipelines CDK Pipelines library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markusl @aws-cdk-automation @rix0rrr