New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudfront-origins): extend readTimeout
maximum value for HttpOriginProps
#18697
feat(cloudfront-origins): extend readTimeout
maximum value for HttpOriginProps
#18697
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…o 180 (#18837) This pull request extends the maximum value of the keepaliveTimeout property for HttpOriginProps up to 180 seconds. This allows the use of the construct also in the case that a limit increase has been approved for CloudFront [origin keep-alive timeout quota](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/distribution-web-values-specify.html#DownloadDistValuesOriginKeepaliveTimeout). The 180 seconds cap should be AWS hard limit for that quota. This is related to #18697, which only extended the readTimeout, but keepaliveTimeout can also be increased. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…pOriginProps` (aws#18697) This pull request extends the maximum value of the `readTimeout` property for `HttpOriginProps` up to 180 seconds. This allows the use of the construct also in the case that a limit increase has been approved for CloudFront [origin request timeout quota](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/cloudfront-limits.html#limits-web-distributions). The 180 seconds cap should be AWS hard limit for that quota. Closes aws#18628 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…o 180 (aws#18837) This pull request extends the maximum value of the keepaliveTimeout property for HttpOriginProps up to 180 seconds. This allows the use of the construct also in the case that a limit increase has been approved for CloudFront [origin keep-alive timeout quota](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/distribution-web-values-specify.html#DownloadDistValuesOriginKeepaliveTimeout). The 180 seconds cap should be AWS hard limit for that quota. This is related to aws#18697, which only extended the readTimeout, but keepaliveTimeout can also be increased. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This pull request extends the maximum value of the
readTimeout
property forHttpOriginProps
up to 180 seconds. This allows the use of the construct also in the case that a limit increase has been approved for CloudFront origin request timeout quota.The 180 seconds cap should be AWS hard limit for that quota.
Closes #18628
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license