Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-lambda-python): Command Hook support #18621

Closed
2 tasks
tmokmss opened this issue Jan 24, 2022 · 7 comments
Closed
2 tasks

(aws-lambda-python): Command Hook support #18621

tmokmss opened this issue Jan 24, 2022 · 7 comments
Labels
@aws-cdk/aws-lambda-python effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@tmokmss
Copy link
Contributor

tmokmss commented Jan 24, 2022

Description

It would be great if PythonFunction also supports command hook feature, which is already supported by NodeJsFunction and GoFunction.

Use Case

e.g. downloading other dependent binaries during bundling a python function.

Proposed Solution

tbw

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@tmokmss tmokmss added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 24, 2022
@corymhall corymhall added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jan 24, 2022
@corymhall
Copy link
Contributor

I am unassigning and marking this issue as p2, which means that we are unable to work on this immediately.

We use +1s to help prioritize our work, and are happy to revaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

@corymhall corymhall removed their assignment Jan 24, 2022
@corymhall corymhall added the effort/small Small work item – less than a day of effort label Jan 26, 2022
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jan 26, 2023
@tmokmss
Copy link
Contributor Author

tmokmss commented Jan 27, 2023

It still should be open.

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jan 27, 2023
@madeline-k
Copy link
Contributor

This is already supported in the aws-lambda-python module: https://docs.aws.amazon.com/cdk/api/v2/docs/@aws-cdk_aws-lambda-python-alpha.BundlingOptions.html#commandhooksspan-classapi-icon-api-icon-experimental-titlethis-api-element-is-experimental-it-may-change-without-noticespan

There is an example in the readme as well: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-lambda-python-alpha-readme.html#command-hooks

Please go try it out! And open new issues if you experience problems with it, or if you have additional feature requests.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@madeline-k
Copy link
Contributor

Shoutout to @webratz who contributed this recently! #23330 🎉

@tmokmss
Copy link
Contributor Author

tmokmss commented Jan 28, 2023

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda-python effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants