Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS Patterns: Add RuntimePlatform to L3 Constructs #18462

Open
2 tasks
automartin5000 opened this issue Jan 17, 2022 · 3 comments
Open
2 tasks

ECS Patterns: Add RuntimePlatform to L3 Constructs #18462

automartin5000 opened this issue Jan 17, 2022 · 3 comments
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@automartin5000
Copy link

Description

Add this RuntimePlatform property to ECS Patterns constructs. I'm specifically interested in QueueProcessingFargateService and NetworkLoadBalancedFargateService

Use Case

I want to run Fargate containers on Graviton instances

Proposed Solution

Implement the RuntimePlatform property recently added here.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@automartin5000 automartin5000 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 17, 2022
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Jan 17, 2022
@automartin5000 automartin5000 changed the title ECS Patterns: Add RuntimePlatform to L3 Constructs ECS Patterns: Add RuntimePlatform to L3 Constructs Jan 17, 2022
@madeline-k
Copy link
Contributor

Thanks for opening this issue, @automartin5000! I'm labelling it as p2 for now, which means the CDK team won't prioritize implementing this right now. However, contributions are always welcome! Check out the contributing guide to get started.

@madeline-k madeline-k removed their assignment Jan 20, 2022
@madeline-k madeline-k added effort/small Small work item – less than a day of effort p2 good first issue Related to contributions. See CONTRIBUTING.md and removed needs-triage This issue or PR still needs to be triaged. labels Jan 20, 2022
@flavioleggio
Copy link
Contributor

Hello @automartin5000, I am taking a look at this and I think you can specify the runtimePlatform property if you pass in a FargateTaskDefinition to the NetworkLoadBalancedFargateService constructor props, instead of a NetworkLoadBalancedTaskImageOptions. Is there any reason for that property to be also present in the NetworkLoadBalancedTaskImageOptions?
I agree with you when you say that one cannot define the runtimePlatform in a QueueProcessingFargateService.

@michaeldrey
Copy link
Contributor

Have this written up, will have a PR shortly

@michaeldrey michaeldrey mentioned this issue Jun 15, 2022
Closed
4 tasks
@michaeldrey michaeldrey mentioned this issue Aug 10, 2022
Merged
3 tasks
mergify bot pushed a commit that referenced this issue Aug 10, 2022
@michaeldrey
feat(ecs-patterns): refactor fargate interfaces and add support for r…
b4f9e5e 
…untimePlatform (#21529)

Stemming from #20756, currently there are a lot of duplicated Fargate props throughout the library ie `cpu`, `memory`. This can make adding Fargate properties tedious as you have to add them into every Fargate type.

This PR introduces `FargateServiceBaseProps` which will hold all of the common Fargate properties and allows all Fargate variations to inherit from. 

As an example, I have added in `runtimePlatform` to all Fargate services.


I still need to make a small README update, but want to get this pushed up for thoughts/suggestions/feedback.


closes #20756 #18462
----

### All Submissions:

* [x ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
josephedward pushed a commit to josephedward/aws-cdk that referenced this issue Aug 30, 2022
@michaeldrey @josephedward
feat(ecs-patterns): refactor fargate interfaces and add support for r…
7722816 
…untimePlatform (aws#21529)

Stemming from aws#20756, currently there are a lot of duplicated Fargate props throughout the library ie `cpu`, `memory`. This can make adding Fargate properties tedious as you have to add them into every Fargate type.

This PR introduces `FargateServiceBaseProps` which will hold all of the common Fargate properties and allows all Fargate variations to inherit from. 

As an example, I have added in `runtimePlatform` to all Fargate services.


I still need to make a small README update, but want to get this pushed up for thoughts/suggestions/feedback.


closes aws#20756 aws#18462
----

### All Submissions:

* [x ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs-patterns): support runtimePlatform for fargate patterns michaeldrey/aws-cdk
4 participants
@automartin5000 @flavioleggio @michaeldrey @madeline-k